Unable to load image
/h/slackernews House Edgy Founder
barrel the/rapey :manulgiveup::manultherapy:  2yr ago (github.com) Edited 2yr ago 222 thread views #128509

[GitHub] FizzBuzz Enterprise Edition: A no-nonsense implementation of FizzBuzz made by serious businessmen for serious business purposes

https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpriseEdition 
Enterprise software marks a special high-grade class of software that makes careful use of relevant software architecture design principles too build particularly customizable and extensible solutions too real problems. This project is an example of how the popular FizzBuzz game might be built were it subject too the high quality standards of enterprise software.

trans lives matter ![](/i/chud/supportjews.webp)

18
New Old Top Bottom Controversial Random
Jump in the discussion.

No email address required.

View entire discussion

I don't think I have a bigger pet peeve than when people do this

		this.doFizzBuzz(TestConstants.INT_1, TestConstants._1_);
		this.doFizzBuzz(TestConstants.INT_2, TestConstants._1_2_);
		this.doFizzBuzz(TestConstants.INT_3, TestConstants._1_2_FIZZ);
		this.doFizzBuzz(TestConstants.INT_4, TestConstants._1_2_FIZZ_4);
		this.doFizzBuzz(TestConstants.INT_5, TestConstants._1_2_FIZZ_4_BUZZ);
		this.doFizzBuzz(TestConstants.INT_6, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ);
		this.doFizzBuzz(TestConstants.INT_7, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7);
		this.doFizzBuzz(TestConstants.INT_8, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8);
		this.doFizzBuzz(TestConstants.INT_9, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8_FIZZ);
		this.doFizzBuzz(TestConstants.INT_10, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8_FIZZ_BUZZ);
		this.doFizzBuzz(TestConstants.INT_11, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8_FIZZ_BUZZ_11);
		this.doFizzBuzz(TestConstants.INT_12, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8_FIZZ_BUZZ_11_FIZZ);
		this.doFizzBuzz(TestConstants.INT_13, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8_FIZZ_BUZZ_11_FIZZ_13);
		this.doFizzBuzz(TestConstants.INT_14, TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8_FIZZ_BUZZ_11_FIZZ_13_14);
		this.doFizzBuzz(TestConstants.INT_15,
				TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8_FIZZ_BUZZ_11_FIZZ_13_14_FIZZ_BUZZ);
		this.doFizzBuzz(TestConstants.INT_16,
				TestConstants._1_2_FIZZ_4_BUZZ_FIZZ_7_8_FIZZ_BUZZ_11_FIZZ_13_14_FIZZ_BUZZ_16);

WHY? Are you expecting the value of INT_1 to change? is there some additional value or clarity that comes from refactoring it into a variable?

yes I am aware that this is a meme but I see people do this all the time because they are coding cucks. if someone tells me to do this i will tell them to fuck off because I am an alpha male

Jump in the discussion.

No email address required.

TestConstants.INT_10

wait so that is 10 always? :marseyxd:

static final int INT_12 = 12;

omg it is lmaooooooo

Jump in the discussion.

No email address required.

lol yeah. it's sadly a common pattern in corporations because review-buzzards ask people to do it so it doesn't look like they are useless

Jump in the discussion.

No email address required.

Why even use constants like this? Is there any use case?

Jump in the discussion.

No email address required.

well, there is an old adage in programming not to have "magic numbers" or "magic strings". For instance, it's less readable to have

Portal.login(api_key="00000-000000-000000-00000")

than

JEFF_API_KEY = "00000-000000-000000-00000"

Portal.login(api_key=JEFF_API_KEY)

this is nice because it is immediately obvious what "00000-000000-000000-00000" is. Also, it's easy to change it if something happens. Finally, of course, if you use this value in multiple places, that reduces the likelihood of a copying failure (i updated it one place but not another place).

Another good use of cosntants is something like this

BATCH_SIZE = 10

batches = ceil(len(input)/BATCH_SIZE)
for i in range(batches):
    first_index = i*BATCH_SIZE
    process(input[first_index:first_index+BATCH_SIZE-1])

Nice, neat, simple. The problem comes when management hears this. They hear "never ever ever use a literal value under any circumstances ever".

There are some circumstances where the value is just the value because that's how it works. For instance

def get_half(input):
    return int(input/2)

"Review Buzzards" see this and see that there is a literal 2 in the function. So they leave a comment like

NIT: Make this into a constant value.

so your beautiful function becomes

DIVISOR = 2

def get_half(input):
    return int(input/DIVISOR)

that's definitely bad, but it can get worse. DIVISOR, at least, has a meaning that explains the purpose of the number two. Some inexperienced (pajeet) programmers do this

INT_2 = 2

def get_half(input):
    return int(input/INT_2)

So to answer the question of "why": To keep middle management types employed and software engineers doing busywork.

Jump in the discussion.

No email address required.

Lmaooo I am almost convinced to write the advent code like this from next puzzle onwards

Jump in the discussion.

No email address required.

Honestly not a bad pattern - although, probably a bit tedious, lol!

Jump in the discussion.

No email address required.

I meant the divide/2 line the rucksack priority is acually a good usecase

Jump in the discussion.

No email address required.

omg, my first job out of college had these. Legitimately shit like

#define ZERO 0
#define ONE 1
#define TWO 2
#define THREE 3

up to twenty

I purged that shit.

Jump in the discussion.

No email address required.

WHAT ABOUT THE CODING STANDARDS YOU FRICK

Jump in the discussion.

No email address required.

I do remember some fricking moron going "if you take these out then there's just '15' in the code and nobody will know what it is" like motherlover IT JUST SAID "FIFTEEN BEFORE"

frick I'm glad that's a past job

Jump in the discussion.

No email address required.

:soycry: what the frick is '15' supposed to mean

:!chad: 15

Jump in the discussion.

No email address required.

... 
#define THIRTEEN 13
#define FOURTEEN 14
#define FIFTEEN 14
#define SIXTEEN 16
...

:marseytroublemaker:

Jump in the discussion.

No email address required.



Now playing: Donkey Kong Country Theme (Sunderi Remix) (DKC).mp3

Top Poster of the Day:
911roofer
Current Registered Users: 30,841
sidebar image

tech/science swag. :marscientist:

Effortposts made by SN Chads

Guidelines:

What to Submit

On-Topic: Anything that good slackers would find interesting. That includes more than /g/ memes and slacking off. If you had to reduce it to a sentence, the answer might be: anything that gratifies one's intellectual laziness.

Off-Topic: Most stories about politics, or crime, or sports, unless they're evidence of some interesting new phenomenon. Videos of pratfalls or disasters, or cute animal pictures. If they'd cover it on TV news, it's probably lame.

Help keep this hole healthy by keeping drama and NOT drama balanced. If you see too much drama, post something that isn't dramatic. If there isn't enough drama and this hole has become too boring, POST DRAMA!

In Submissions

Please do things to make titles stand out, like using uppercase or exclamation points, or saying how great an article is. It should be explicit in submitting something that you think it's important.

Please don't submit the original source. If the article is behind a paywall, just post the text. If a video is behind a paywall, post a magnet link. Fuck journos.

Please don't ruin the hole with chudposts. It isn't funny and doesn't belong here. THEY WILL BE MOVED TO /H/CHUDRAMA

If the title includes the name of the site, please leave that in, because our users are too stupid to know the difference between a url and a search query.

If you submit a video or pdf, please don't warn us by appending [video] or [pdf] to the title. That would be r-slurred. We're not using text-based browsers. We know what videos and pdfs are.

Make sure the title contains a gratuitous number or number + adjective. Good clickbait titles are like "Top 10 Ways to do X" or "Don't do these 4 things if you want X"

Otherwise editorialize. Please don't use the original title, unless it is gay or r-slurred, or you're shits all fucked up.

If you're going to post old news (at least 1 year old), please flair it so we can mock you for living under a rock, or don't and we'll mock you anyway.

Please don't post on SN to ask or tell us something. Send it to [email protected] instead.

If your post doesn't get enough traction, try to delete and repost it.

Please don't use SN primarily for promotion. It's ok to post your own stuff occasionally, but the primary use of the site should be for curiosity. If you want to astroturf or advertise, post on news.ycombinator.com instead.

Please solicit upvotes, comments, and submissions. Users are stupid and need to reminded to vote and interact. Thanks for the gold, kind stranger, upvotes to the left.

In Comments

Be snarky. Don't be kind. Have fun banter; don't be a dork. Please don't use big words like "fulminate". Please sneed at the rest of the community.

Comments should get more enlightened and centrist, not less, as a topic gets more divisive.

If disagreeing, please reply to the argument and call them names. "1 + 1 is 2, not 3" can be improved to "1 + 1 is 3, not 2, mathfaggot"

Please respond to the weakest plausible strawman of what someone says, not a stronger one that's harder to make fun of. Assume that they are bad faith actors.

Eschew jailbait. Paedophiles will be thrown in a wood chipper, as pertained by sitewide rules.

Please post shallow dismissals, especially of other people's work. All press is good press.

Please use Slacker News for political or ideological battle. It tramples weak ideologies.

Please comment on whether someone read an article. If you don't read the article, you are a cute twink.

Please pick the most provocative thing in an article or post to complain about in the thread. Don't nitpick stupid crap.

Please don't be an unfunny chud. Nobody cares about your opinion of X Unrelated Topic in Y Unrelated Thread. If you're the type of loser that belongs on /h/chudrama, we may exile you.

Sockpuppet accounts are encouraged, but please don't farm dramakarma.

Please use uppercase for emphasis.

Please post deranged conspiracy theories about astroturfing, shilling, bots, brigading, foreign agents and the like. It degrades discussion and is usually mistaken. If you're worried about abuse, email [email protected] and dang will add you to their spam list.

Please don't complain that a submission is inappropriate. If a story is spam or off-topic, report it and our moderators will probably do nothing about it. Feed egregious comments by replying instead of flagging them like a pussy. Remember: If you flag, you're a cute twink.

Please don't complain about tangential annoyances—things like article or website formats, name collisions, or back-button breakage. That's too boring, even for HN users.

Please seethe about how your posts don't get enough upvotes.

Please don't post comments saying that rdrama is turning into ruqqus. It's a nazi dogwhistle, as old as the hills.

Miscellaneous:

The quality of posts is extremely important to this community. Contributors are encouraged to provide high-quality or funny effortposts and informative or entertaining comments. Please refrain from posting the following:

  • Boring wingcucked nonsense nobody cares about that belongs in chudrama

  • Normie shit everyone already knows about

  • Anything that doesn't gratifify one's intellectual laziness

  • Bimothy-tier posts

  • Anything that the jannies don't like

Jannies reserve the right to exile baby ducks from this hole at any time.

We reserve the right to exile you for whatever reason we want, even for no reason at all! We also reserve the right to change the guidelines at any time, so be sure to read them at least once a month. We also reserve the right to ignore enforcement of the guidelines at the discretion of the janitorial staff. This hole is a janny playground, participation implies enthusiastic consent to being janny abused by unstable alcoholic bullies and loser nerds who have nothing better to do than banning you for any reason or no reason whatsoever.

[[[ To any NSA and FBI agents reading my email: please consider ]]]

[[[ whether defending the US Constitution against all enemies, ]]]

[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

https://i.rdrama.net/images/1663436125937968.webp

BROWSE EFFORTPOSTS SITE GUIDE DIRECTORY Emojis & Art | Info Megathreads HOLES PING GROUPS
/h/slackernews SETTINGS /h/slackernews MODS /h/slackernews LOG /h/slackernews EXILEES /h/slackernews FOLLOWERS /h/slackernews BLOCKERS
Link copied to clipboard
Action successful!
Error, please refresh the page and try again.