So I was called into fix this UNFIXABLE CSS bug in an application. I am not even a css expert and they for some reason they call me to fix this shit. well anyway the bug is that some of the fonts are not working on some screens .
I go look at the css and the scss files and what do I see? this shit (SEE IMAGE). The red is old, bottom is what I fixed. You know what they did?
for @font-face
they used the entire font-family string so basically they setup the @font-face
as
"'ourcustomsansfont', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif"
this makes the name of this font as that WHOLE string, no, not ourcustomsansfont
like it should be.
then they go on using the whole string in the font-family
atrribute like this
font-family: "'ourcustomsansfont', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif"
thats the name of a single font. no, they are not fallback font, THAT WHOLE THING IS A SINGLE FONT NAME. IMAGINE THAT
NOW IM HERE WORKING TILL 3AM because of these retards who couldn't visit w3cschools and understand how to declare a @font-face
This whole thing has 40+ references in the code and I had to search replace change it from
font-family: "'ourcustomsansfont', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif";
to this
font-family: ourcustomsansfont, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif;
and the @font-face
to
@font-face: "ourcustomsansfont"
Jump in the discussion.
No email address required.
lol this neighbor has to do CSS on the daily
Jump in the discussion.
No email address required.
I don't but I'm the "architect" so I was called in to check which something no one able to fix apparently. utterly ridiculous. I am gonna karen the heck out tomorrow when their manager comes
Jump in the discussion.
No email address required.
More tech layoffs soon
Jump in the discussion.
No email address required.
More options
Context
If you're the architect you gotta architect that shit so they have to look up the font name from a relational database. Not because that's necessarily a good way to do thing but at least in a database you know only men are getting in there, not front-end "developer" office ladies like @HardIsLife.
Jump in the discussion.
No email address required.
I didn't consult on this project at all, If I did it wouldn't be like this. There is so much technical debt on this project, its insane! I made notes, I am telling the manager and his manager tomorrow and blasting them for wasting my time.
Jump in the discussion.
No email address required.
More options
Context
hil is a dev?
Jump in the discussion.
No email address required.
Yeah, I used to make fun of her for being a mere girl developer back in DeuxRAMA days. Good times.
Jump in the discussion.
No email address required.
More options
Context
no, a front-end code monkey
Jump in the discussion.
No email address required.
More options
Context
More options
Context
More options
Context
More options
Context
More options
Context