emoji-award-capyhacker
Unable to load image

Calling on @Aevann to Approve MarseyFX!

I am humbly calling upon @MURDERVANN to merge my MarseyFX pull request (it's finished now).

!codecels

FAQ

1. Is it backwards compatible? What about the emotes already posted, will those be broken?

It's mostly backwards compatible. Emotes that have already been posted have already been rendered and as such will not be effected by the new rendering engine. In terms of new posts, emotes are essentially the same, except that you'll need a dot . before modifiers: :marseylove: becomes :marsey.love:

2. What about the preview stuff?

The preview is not up-to-date, so it won't be able to render the new MarseyFX stuff. Options currently are to transpile the MarseyFX parser from Python to JS using something like JavaScripthon; run the python code in the browser through something like PyScript; send the data back to the server in order to be rendered; implement a subset of the renderer in JS; or leave it out entirely.

32
Jump in the discussion.

No email address required.

There are no unit tests for any of the code you've written. I know you've said that "it's tested thoroughly it'll work I swear", but unit tests also serve as a spec of how it should behave and make it much easier to modify and extend in the future without breaking it.

There's also the problem of making it work on the client, but I see that someone has offered to do that.

Other people have talked about this, but this would require users to change how they enter emojis, and you know how end users (especially non-technical ones) hate change.

Jump in the discussion.

No email address required.

rdrama


unit tests

Lol lmao even


:#marseyviewerstaretalking:

Jump in the discussion.

No email address required.

>creates entire parser/dsl for cartoon cats on an obscure website

>only tests it manually

The absolute state of codecels. Though I suppose the socks :marseyfemboy: mean that all code is correct and doesn't need to be tested

Jump in the discussion.

No email address required.

Link copied to clipboard
Action successful!
Error, please refresh the page and try again.